Appearance
QA UX review: shared shell
Scope: sidebar, top bar, notification bell and panel, account menu, theme, skeletons, shared time formatter.
Scores (1 to 10)
| Area | Desktop | Mobile 390px | Notes |
|---|---|---|---|
| Clarity of purpose | 7 | 7 | Space title in the top bar; nav labels are plain. |
| Visual hierarchy | 7 | 6 | Nav active state is a muted fill, quiet but easy to miss. |
| Consistency across roles | 6 | 6 | Skeleton used the owner page shape for every role. |
| Forms and feedback states | 6 | 6 | Panel had loading, error, empty; "Mark all read" disabled with no reason. |
| Accessibility | 7 | 7 | Bell has count in its label, Escape closes and returns focus. Sidebar trigger has a label. |
| Keyboard and focus order | 7 | 6 | Bell closed on outside click also stole focus back to the bell. |
| Dark theme contrast | 8 | 8 | muted-foreground is oklch 0.72 on 0.165 background; primary is 0.74. Both comfortably pass AA. |
| Speed to main task | 8 | 8 | One click to a page; sign-out is one menu step. |
What works
- The bell has the unread count in its accessible name and as a badge; the panel closes on Escape and on navigation.
- Notification links are checked to be internal paths, so a stored link cannot send the user off-site.
- Loading, error (with retry) and empty states all exist in the panel.
- The sidebar uses
aria-currenton the active item and the trigger carries a label. - Dark theme tokens are defined as a full set and used through token classes only.
Suggestions
- P1: Notification times were formatted in the browser time zone with no year. Fixed: now
formatDateTimein London time.apps/web/src/components/notifications/notification-panel.tsx - P1: Shared formatter did not exist. Added
apps/web/src/lib/format-time.tswithformatDay,formatTime,formatDateTime, all Europe/London. - P2: "Mark all read" was disabled with no explanation. It now reads "All read" when nothing is unread.
notification-panel.tsx - P2: The loading block used an
aria-labelon a plain div, which screen readers do not announce. It is now arole="status"region with visible-to-AT text.notification-panel.tsx - P2: Clicking anywhere outside the open panel moved focus back to the bell, which is wrong for a pointer click on other content. Focus now returns to the bell only on Escape.
notification-bell.tsx - P2: The open panel had no name. It is now a labelled region.
notification-bell.tsx - P2: Skeleton showed the owner page shape for every role. It now uses the owner skeleton under
/owner, the client skeleton under/client, and a neutral title-and-list shape otherwise.apps/web/src/components/skeletons/app-shell-skeleton.tsx - P3: Skeleton top bar omits the search and docs controls that the real bar shows. Not changed; the skeleton reserves their width already.
- P3: The sidebar and account menu are not role-tested in the screenshots I could read here. Not changed; needs a browser pass.
- P3: Sign-out has no confirmation. Not changed: it is reversible by signing in again, so confirmation would add a step for no safety gain.
Done / not done
- 1 Done. 2 Done. 3 Done. 4 Done. 5 Done. 6 Done. 7 Done.
- 8 Not done (trivial, skeleton width is already reserved).
- 9 Not done (needs a browser pass, out of scope for this change).
- 10 Not done (reason above).